I think people got hung up on the investment aspect of DVC or lack thereof and might have missed the bigger point. Regardless of labels, I think the idea was to compare the financial implications of both potential purchases. The stock is a likely appreciating asset that will give you almost no joy whatsoever, aside from the joy that comes from seeing a number on a screen grow larger over time (hopefully). DVC is a lifestyle choice. It will likely improve your vacations and your happiness. Financially speaking it is a cost-mitigation vehicle, or at least it was in its original design, but I don't want to go down that road here. Let's just say I agree with the previous posters who cite the unrepeatability of some historical DVC gains. I will say that the cost mitigation still may exist, but it is not as substantial as it once was.
That said, there have been a few instances where people have done very well "day trading" DVC and have outperformed the DOW, Disney Stock, and stocks in general. It's fraught with risk and uncertainty and I would not recommend it, but it can be done.
Your financial advisor is likely not going to recommend DVC. But you don't have to follow her advice. You also don't have to follow the advice of a bunch of biased strangers on a Disney chat forum.