Splurges we go for:
Staying on property, particularly deluxe resorts for the location advantage (we do split stays to maximize this), although we like the moderate resorts too
Table service dining, including signature restaurants and character breakfasts (we don't do character lunches or dinners)
Long stays (10 days or more) that include visiting the water parks
Flying in, as opposed to driving (although I don't know if anyone would really classify flying coach on a domestic airline as "splurging")
Splurges we skip:
Dessert or tea parties
Merchandise (rather spend money on experiences as opposed to things)
Club level (we're teatotallers who like hearty breakfasts)
Spa treatments
Dress-up type experiences (BBB, Pirates League, etc.)
Guided tours
I guess I don't find it as absolute. From one trip to another a splurge may have to be a skip, depending on how much money I had to spend. When I had trips where two of us were dividing the trip cost equally, I was able to afford a Deluxe. In my 2013, even though I was paying for the whole trip for the two of us, I got great airfare and was able to stay at a moderate. Last year, and this year, I have to do a value, even though I'm basically spending the same amount, and I did not get free dining. I also always just book a standard view.
By your definitions of what is splurging, then I would have quite a few splurges.
I guess if it's a splurge to stay on property, then that is one splurge that I would always want to do. I don't want to rent a car, and would rather use WDW transportation.
I fly, because I live in PA, and I would rather stick an ice pick in my eye, than drive from PA to Florida. I fly coach. I physically could never drive that long, and even if someone else drove, that long in a car, would be complete torture for me. Not that I enjoy flying, and having to take two planes to get there, but it's better than driving.
I need to do at least one Table Service meal per day, due to diet requirements. I have dysphagia and need soft foods, and have some allergies, and so TS allows them to hopefully try and cook something for me that I can actually swallow and eat. Where quick service meals, you don't really have a choice, the food is what it is, and I simply cannot swallow things like burgers or sandwiches, really. So, TS would always be a "splurge" for me. Just so happens that I've had the best luck with actually being able to eat (breakfast) at Crystal Palace and Tusker House, and they are character meals, so I will always "splurge" and try and get those ADRs.
We do have an ADR for Afternoon Tea at the GF.
I buy some sort of souvenir for myself. I always buy at least a hoodie.
Last year, we did MNSSHP, for the first time. I LOVE Halloween, it's my favorite holiday. This year, we are going in November, since it's always been my dream to see MK decorated for Xmas. This year, I didn't get park hoppers. And got tickets for MVMCP instead.
My line, is to stay within the confines of my budget for the trip. If I had more money, I would be doing more splurging. Lol. If I had money, I would be doing club level, a spa day, and a guided tour.