Financial advisors usually advise this way. The sentiment is that if you have the cash, it should be in savings, an IRA, 401K, etc. making money for you. Finance whatever you can and if you end up in a bad way, then fall back on that cash to pay it off to dig yourself out of that hole. It may seem counterintuitive since you're typically paying interest on something you're financing, but the thought is that if you can afford the payment, only spend your cash as a last resort.
With this in mind, I think financing DVC can make sense, but only for those who have investments and/or cash on hand to afford the total cost. If you couldn't otherwise afford to pay for the contract in cash, then its hard to justify taking the value of that monthly payment and spending it on something like a timeshare as opposed to a retirement account or stocks that would be a more worthwhile investment. But investment accounts are intangible and you don't reap the value of them in the present, like you would a timeshare. So I understand the emotion behind financing a timeshare, but practically speaking, I can't think of a scenario where its a good financial decision.