My family and I had APs in 2017/18. Having APs caused us to make several trips on short notice. We live about 9 hours away and don't mind the drive. I was going to buy APs again as our son is doing DCP in the spring of 2020. No big problem. We won't visit him as much as we may have otherwise. The AP value for me is in the park entrance and free parking, because I don't care anything about Memory Maker and don't buy enough merch to make the discount mean much.
I'm sure it still works for some folks, but it doesn't really fit our style. Although I sure will miss hopping in the car and going to WDW whenever DW and I could get a few days clear on our calendars. On a side note, DW and I are going to Paris for a week later this month, and that is costing me about the same as the January 2020 5-day WDW trip we have planned -and no, we won't be staying at a deluxe resort. Yikes!